Skip to content

FINERACT-2436: Fix PostgreSQL compatibility for Client Weekly and Monthly Trends Reports#5477

Open
Kengne-yvana wants to merge 1 commit intoapache:developfrom
Kengne-yvana:FINERACT-2436-client-trends-postgres-fix
Open

FINERACT-2436: Fix PostgreSQL compatibility for Client Weekly and Monthly Trends Reports#5477
Kengne-yvana wants to merge 1 commit intoapache:developfrom
Kengne-yvana:FINERACT-2436-client-trends-postgres-fix

Conversation

@Kengne-yvana
Copy link
Contributor

@Kengne-yvana Kengne-yvana commented Feb 11, 2026

…thly Trends Reports

Description

Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

@Kengne-yvana Kengne-yvana changed the title FINERACT-2436: Fix PostgreSQL compatibility for Client Weekly and Mon… FINERACT-2436: Fix PostgreSQL compatibility for Client Weekly and Monthly Trends Reports Feb 11, 2026
@Kengne-yvana Kengne-yvana force-pushed the FINERACT-2436-client-trends-postgres-fix branch from 9f6a434 to 1c40e35 Compare February 12, 2026 09:55
@Kengne-yvana
Copy link
Contributor Author

Kengne-yvana commented Feb 13, 2026

@IOhacker please i am waiting for a review.

@Kengne-yvana Kengne-yvana force-pushed the FINERACT-2436-client-trends-postgres-fix branch 2 times, most recently from 9703641 to ef25373 Compare February 17, 2026 03:54
adamsaghy
adamsaghy reviewed Feb 17, 2026
View reviewed changes
...vider/src/main/resources/db/changelog/tenant/parts/0210_postgresql_client_trends_reports.xml Outdated
Comment on lines +28 to +30
<preConditions onFail="MARK_RAN">
<dbms type="postgresql"/>
</preConditions>
Copy link
Contributor

@adamsaghy adamsaghy Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed

adamsaghy
adamsaghy reviewed Feb 17, 2026
View reviewed changes
...vider/src/main/resources/db/changelog/tenant/parts/0210_postgresql_client_trends_reports.xml Outdated
Comment on lines +43 to +45
<preConditions onFail="MARK_RAN">
<dbms type="postgresql"/>
</preConditions>
Copy link
Contributor

@adamsaghy adamsaghy Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed

@adamsaghy
Copy link
Contributor

adamsaghy commented Feb 17, 2026

@Kengne-yvana Please rebase this PR with latest develop branch.

@Kengne-yvana Kengne-yvana force-pushed the FINERACT-2436-client-trends-postgres-fix branch from ef25373 to e6e0a83 Compare February 17, 2026 12:23
@Kengne-yvana
Copy link
Contributor Author

Kengne-yvana commented Feb 17, 2026

@adamsaghy done

@adamsaghy
Copy link
Contributor

adamsaghy commented Feb 18, 2026

@Kengne-yvana Please rebase this PR with latest develop branch.

@adamsaghy
Copy link
Contributor

adamsaghy commented Feb 20, 2026

@Kengne-yvana Please rebase this PR with latest develop branch.

Also you might wanna cover this report with a test case! ;)

@Kengne-yvana Kengne-yvana force-pushed the FINERACT-2436-client-trends-postgres-fix branch 5 times, most recently from f48b65e to 0eb2f20 Compare February 20, 2026 16:25
@Kengne-yvana
Copy link
Contributor Author

Kengne-yvana commented Feb 21, 2026

@adamsaghy done thanks

@adamsaghy
Copy link
Contributor

adamsaghy commented Feb 23, 2026

@Kengne-yvana Please rebase this PR with latest develop branch.

You might wanna check the failing test cases!

@adamsaghy
Copy link
Contributor

adamsaghy commented Feb 23, 2026

@Kengne-yvana Please rebase this PR with latest develop branch.

@Kengne-yvana Kengne-yvana force-pushed the FINERACT-2436-client-trends-postgres-fix branch 4 times, most recently from e547969 to 9a2be2b Compare February 23, 2026 20:39
@adamsaghy
Copy link
Contributor

adamsaghy commented Mar 2, 2026

@Kengne-yvana Please rebase this PR with latest develop branch.

@adamsaghy
Copy link
Contributor

adamsaghy commented Mar 2, 2026 


* What went wrong:
Execution failed for task ':integration-tests:spotlessJavaCheck'.
> The following files had format violations:
      src/test/java/org/apache/fineract/integrationtests/ClientTrendsPostgresTest.java
          @@ -23,7 +23,6 @@
gradle/actions: Writing build results to /home/runner/work/_temp/.gradle-actions/build-results/__run-1771880762564.json
           import·java.io.IOException;
           import·java.util.HashMap;
           import·java.util.Map;
          -
           import·org.apache.fineract.integrationtests.common.FineractClientHelper;
           import·org.apache.fineract.integrationtests.common.Utils;
           import·org.apache.fineract.integrationtests.common.report.ReportHelper;
          @@ -43,14 +42,14 @@
           ····@Test

[Incubating] Problems report is available at: file:///home/runner/work/fineract/fineract/build/reports/problems/problems-report.html
           ····public·void·testClientTrendsReportsPostgresSyntax()·throws·IOException·{
           ········Map<String,·String>·reportParameters·=·new·HashMap<>();
          -········reportParameters.put("officeId",·"1");·
          +········reportParameters.put("officeId",·"1");
           
           ········var·reportsRunApi·=·FineractClientHelper.getFineractClient().reportsRun;
           
          -········assertTrue(reportsRunApi.runReportGetFile("ClientTrendsByWeek",·reportParameters,·false).execute().isSuccessful(),·
          -············"Postgres·Weekly·Report·SQL·syntax·is·invalid!");
          +········assertTrue(reportsRunApi.runReportGetFile("ClientTrendsByWeek",·reportParameters,·false).execute().isSuccessful(),
          +················"Postgres·Weekly·Report·SQL·syntax·is·invalid!");
           
          -········assertTrue(reportsRunApi.runReportGetFile("ClientTrendsByMonth",·reportParameters,·false).execute().isSuccessful(),·
          -············"Postgres·Monthly·Report·SQL·syntax·is·invalid!");
          +········assertTrue(reportsRunApi.runReportGetFile("ClientTrendsByMonth",·reportParameters,·false).execute().isSuccessful(),
          +················"Postgres·Monthly·Report·SQL·syntax·is·invalid!");
           ····}
           }
  Run './gradlew :integration-tests:spotlessApply' to fix these violations.

@Kengne-yvana Kengne-yvana force-pushed the FINERACT-2436-client-trends-postgres-fix branch from 9a2be2b to 5480a97 Compare March 3, 2026 07:29
@adamsaghy
Copy link
Contributor

adamsaghy commented Mar 3, 2026

@Kengne-yvana Please resolve the conflicts. One recommendation: instead of merge you should use rebase ;)

@Kengne-yvana Kengne-yvana force-pushed the FINERACT-2436-client-trends-postgres-fix branch from bb2d75b to 5480a97 Compare March 3, 2026 08:36
@Kengne-yvana Kengne-yvana force-pushed the FINERACT-2436-client-trends-postgres-fix branch 2 times, most recently from 21291c5 to c098b98 Compare March 3, 2026 08:44
@Kengne-yvana
Copy link
Contributor Author

Kengne-yvana commented Mar 3, 2026

@Kengne-yvana Please resolve the conflicts. One recommendation: instead of merge you should use rebase ;)

thanks @adamsaghy Done

@Kengne-yvana Kengne-yvana force-pushed the FINERACT-2436-client-trends-postgres-fix branch from c098b98 to f7279b8 Compare March 3, 2026 15:20
@IOhacker
Copy link
Contributor

IOhacker commented Mar 3, 2026

@Kengne-yvana take a look at the failing test in the Github actions

@Kengne-yvana
Copy link
Contributor Author

Kengne-yvana commented Mar 3, 2026

yes that is what i am doing right now, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adamsaghy adamsaghy adamsaghy left review comments

+1 more reviewer

@Aman-Mittal Aman-Mittal Aman-Mittal left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Kengne-yvana @adamsaghy @IOhacker @Aman-Mittal